Re: [PATCH 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.y:
>          destroy_instr_list($2);
>      }
>  | hlsl_prog preproc_directive
> - | hlsl_prog technique
> | hlsl_prog ';'
>
> +technique_name:
> -
>  %empty
> -
>    {
> -
>        $$ = NULL;
> -
>    }
> - | var_identifier

This doesn't match my testing. According to my testing, it should be NEW_IDENTIFIER, or (probably better) any_identifier with a check for already defined variables and types.