Re: [PATCH 0/17] MR541: RFC: Shader cache for vkd3d

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d/cache.c:
> +#include "vkd3d_private.h"
> +#include "rbtree.h"
> -
>
> +#include <stdarg.h>
> +#include <stdio.h>
> -
>
> +int vkd3d_shader_cache_open(const char *name,
> -
>    const struct vkd3d_shader_cache_desc *desc, struct vkd3d_shader_cache **cache)
>
> +{
> - FIXME("%s, %p, %p: stub!\n", debugstr_a(name), desc, cache);
> - return VKD3D_ERROR_NOT_IMPLEMENTED;
>
> +}
> -
>
> +void vkd3d_shader_cache_close(struct vkd3d_shader_cache *cache)
> +{
> - FIXME("Stub!\n");

Nitpick, but maybe `cache` should be dumped. Also in `vkd3d_shader_cache_delete_on_destroy()`.