Re: [PATCH v18 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
> -
>        while (list_next(&s->cases, &def->entry))
> -
>        {
> -
>            c = LIST_ENTRY(list_next(&s->cases, &def->entry), struct hlsl_ir_switch_case, entry);
> -
>            if (!list_empty(&c->body.instrs))
> -
>                break;
> -
>            hlsl_free_ir_switch_case(c);
> -
>        }
> -
> -
>        /* Merge with the next case. */
> -
>        if (list_next(&s->cases, &def->entry))
> -
>        {
> -
>            c = LIST_ENTRY(list_next(&s->cases, &def->entry), struct hlsl_ir_switch_case, entry);
> -
>            c->is_default = true;
> -
>            hlsl_free_ir_switch_case(def);
> -
>            def = c;
> -
>        }

Is this correct? It seems to assume that the `default` case is empty, so the following case must become `default`; but the `default` might already have a body terminated by a break. This might be the reason tests are failing, I didn't investigate.