Nikolay Sivov (@nsivov) commented about dlls/d2d1/tests/d2d1.c:
hr = ID3D10Device_CreateTexture3D(d3d_device, &texture_desc, NULL, &texture);
ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
hr = ID3D10Texture3D_QueryInterface(texture, &IID_IDXGIResource1, (void **)&resource);
ID3D10Texture3D_Release(texture);
}
else
{
ok(0, "Unexpected resource type %u.\n", subresource_tests[i].resource_type);
winetest_pop_context();
continue;
}
subresource_count = subresource_tests[i].mip_levels * subresource_tests[i].array_size;
expect_parent_surface = subresource_count == 1;
for (j = 0; j < subresource_count; j++)
{
Checking every subresource seems unnecessary. I think it's enough to have tests for count>1 and index=1. Case for count==1 is the same as our existing tests, right?