Re: [PATCH v5 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/cfgmgr32/tests/cfgmgr32.c:
> -
>    { CR_QUERY_VETOED,             0xdeadbeef },
> -
>    { CR_CANT_SHARE_IRQ,           0xdeadbeef },
> -
>    { CR_NO_DEPENDENT,             0xdeadbeef },
> -
>    { CR_SAME_RESOURCES,           0xdeadbeef },
> -
>    { CR_DEVICE_INTERFACE_ACTIVE,  0xdeadbeef },
> -
>    { CR_INVALID_CONFLICT_LIST,    0xdeadbeef },
> -
>    { CR_INVALID_INDEX,            0xdeadbeef },
> -
>    { CR_INVALID_STRUCTURE_SIZE,   0xdeadbeef },
> -
>    { NUM_CR_RESULTS,              0xdeadbeef },
> - };
> -
> - for ( i = 0; i < sizeof(map_codes) / sizeof(map_codes[0]); i++ )
> - {
> -
>    ret = 0xdeadbeef;
> -
>    ret = CM_MapCrToWin32Err( map_codes[i].code, 0xdeadbeef );
> -
>    ok( ret == map_codes[i].win32_error, "expected %ld, got %ld.\n", map_codes[i].win32_error, ret );

This doesn't give enough information to tell which test failed. Better to specify the CM error code, and then there's no need to specify the expected error.