On Fri Sep 6 13:14:52 2024 +0000, Alexandros Frantzis wrote:
Taking a step back, what's the reason for detaching the client surface
when the window is hidden? The compositor will handle this for us, not showing any subsurfaces if the parent surface is not mapped. (This compositor behavior is good enough for now, while we are not yet dealing with GL/VK in (possibly nested) child surfaces)
I wanted to introduce the changes more gradually in preparation for the later changes which will attach/detach the clients to different toplevel surfaces. It's probably a matter of pulling more of the later changes in now, for instance attaching/detaching the client windows in `wayland_win_data_update_wayland_surface`, unless you mean that we don't need to bother and that we don't need to detach the client windows before destroying / clearing the toplevel surface role?