On Tue Jul 4 13:32:42 2023 +0000, Matteo Bruni wrote:
I think the callers already do essentially the same if necessary, and this one call inside two branches seems unlikely to cover it in case they don't. It makes sense to have this change in a separate patch though. I'll update and resend.
Hmm, looking through this, this is called either from the blitter (in which case we are blitting *to* current_rt and shouldn't need to load it, though we may need to prepare it) or from texture2d_read_from_framebuffer(). In either case I'm not sure that we're actually preparing/loading the texture in the caller, though? I do think it should be the caller's responsibility, but I'm not sure that the callers are correctly handling things.