On Wed Feb 28 07:33:17 2024 +0000, Conor McCarthy wrote:
Not necessarily an issue, but there's a mismatch here between how blocks are added to `sorter` and how they are removed. The former uses a helper function on `struct vsir_cfg_node_sorter`, while the latter accesses an internal member of the struct. I get that `vsir_cfg_make_node_available()` ends up doing a lot more than `vsir_block_list_remove_index()` though. Also, do we need the `vsir_` prefix on `vsir_cfg_make_node_available()`, and should it be `cfg_node_sorter_make_node_available()`?
It's not just a matter of doing more work, but mostly the fact that `make_node_available()` is called from two different places, and I don't want to duplicate that. OTOH node removal is done just in one place and there is nothing to deduplicate. So I'm inclined to leave this as it is.
For the prefix, I'm using `vsir_cfg_` everywhere, and unless we have a stricter policy that I missed I'd leave it as it is too. However I added `note_sorter`.