Re: [PATCH v2 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/ntoskrnl.exe/ntoskrnl.c:
>  FIXME("%p, %d stub\n", dpc, number);
>
> }
>
> +/***********************************************************************
> -
> -
>      KeGetCurrentProcessorNumberEx   (NTOSKRNL.EXE.@)
> - */
>
> +ULONG WINAPI KeGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER ProcNumber)
> +{
> - if(ProcNumber) FIXME("Unhandled ProcNumber\n");

Space after if. ProcNumber -> process_number. And the parameter is optional so you need to check for NULL pointers. Also, I think the PROCESSOR_NUMBER structure is simple enough to be stubbed as well. Just report all Group and Reserved as zero and Number from NtGetCurrentProcessorNumber() and then print a FIXME. A FIXME at the start saying the function is a semi-stub is also helpful.