On Tue Sep 26 22:22:44 2023 +0000, Rémi Bernon wrote:
You can probably just leave that case unimplemented, with a FIXME. It's probably not supposed to happen and you're only interested in handling the case where a format change is detected but it's not actually changing anything visible in the media type. I'd also suggest using a `compare_media_types` helper that you can copy from some other module.
I don't know how many emails/etc gitlab sends, so I'm not sure if you saw it, but I implemented the entire thing; I think it's correct, but there's a fixme for the lack of tests (adding that is too far out of scope to belong in this MR).
I could remove it if you don't want untested code floating around; now that I know what exactly it's trying to do, and what it's actually doing, it's not hard to work around it in the test instead.