Re: [PATCH v2 0/2] MR7491: cmd: Introduce MODE command

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/cmd/builtins.c:
> - int argno;
> -
> - errorlevel = 0;
> - console = CreateFileW(L"CONOUT$", GENERIC_READ|GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE,
> -
>                      NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
> -
> - SystemParametersInfoA(SPI_GETKEYBOARDSPEED, 0, &keybd_speed, 0);
> - SystemParametersInfoA(SPI_GETKEYBOARDDELAY, 0, &keybd_delay, 0);
> - GetConsoleScreenBufferInfo(console, &inf);
> -
> - for (argno = 1; ; argno++)
> - {
> -
>    WCHAR *arg = WCMD_parameter_with_delims(args, argno, &argN, FALSE, FALSE, L" ");
> -
>    if (!*arg) break;
> -
> -
>    if (!wcsnicmp(arg, L"COLS=", 5) && (inf.dwSize.X = wcstoul(arg+5, NULL, 10)))

native fails if lhs is not only made of numbers... (eg cols=12a fails unlike this code)