Re: [PATCH v2 0/8] MR1684: d3d10/effect: Further improvements to expressions support.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3d10/effect.c:
> - unsigned int i;
> -
> - *retval = 0.0f;
> - for (i = 0; i < instr->comp_count; ++i)
> -
>    *retval += args[0][instr->scalar ? 0 : i] * args[1][i];
>
> +}
> -
>
> +static void pres_dotswiz(float **args, unsigned int n, const struct preshader_instr *instr)
> +{
> - float *retval = args[n];
> - unsigned int i;
> -
> - *retval = 0.0f;
> - for (i = 0; i < n; ++i)
> -
>    *retval += *args[i] * *args[i + n / 2];
>
> +}

This doesn't look right to me either.

In any case, I think we want a test for this right away.