On Thu Jul 21 13:55:09 2022 +0000, Piotr Caban wrote:
The patch also affects do_after==3 (cast op) and do_after==4 (string literal) cases (maybe commit message can be improved). The do_after==3 case is kind of covered by next patch. It would be good to also cover do_after==4 case in tests. According to a quick test "_C" demangling is currently broken but a todo_wine test can still document it. While it's not really related to the patch it would be good to define some kind of enum that can be used instead of 1..4 constants. These are some general thoughts (I don't think that this patch should be blocked by anything above).
Hi Piotr,
I'll resend with updated commit message; should be something like 'template support is orthogonal to methods special name handling (ctor/dtor/cast operator...). In all cases, if we need to support templates in do_after 3/4 cases (I haven't tested if this is even a valid C++ construct), current code is broken (as template part will not be generated) => to be tested in other patches
agreed for having an enum for do_after (but I'm starting by removing the unneeded values first ;-) (I'd like to get rid of do_after=4, but need to be sure it doesn't require templates support)