25 Jan
2023
25 Jan
'23
5:54 p.m.
On Wed Jan 25 17:54:16 2023 +0000, Piotr Caban wrote:
The patch looks good for me. It will need to be rebased, mainly to confirm that test pipeline passes this time. Is the version check correct for `__alloc_size__`? Kernel disables it for gcc <= 9.1 with following comment:
/* * Prior to 9.1, -Wno-alloc-size-larger-than (and therefore the "alloc_size" * attribute) do not work, and must be disabled. */
Great, I'll push a new version shortly. I don't think the [kernel's reasoning for disabling it on < 9.1](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...) applies to us, they have a code-path which could return `SIZE_MAX` as an allocation size (a sentinel for overflow which is caught at runtime) and this triggered false-positive `alloc-size-larger-than` warnings on < 9.1.