Re: [PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/recordset.c:
> - ULONG colcnt;
> -
> - TRACE( "%p, %s, %ld, %d, %s\n", recordset, debugstr_w(criteria), skip_records, search_direction,
>        debugstr_variant(&start) );
> - return E_NOTIMPL;
> -
> - if (recordset->state != adStateOpen) return MAKE_ADO_HRESULT( adErrObjectClosed );
> -
> - if (!recordset->criteria || wcscmp(recordset->criteria, criteria) != 0)
> - {
> -
>    clear_recordset_filter(recordset);
> -
> -
>    recordset->criteria = SysAllocString(criteria);
> -
> -
>    /* Parse criteria */
> -
>    recordset_parse_filter(criteria, recordset);

Should we handle the return value here?