Re: [PATCH v2 0/3] MR5685: Implement MarkupServices_ParseString

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmldoc.c:
> - IHTMLElement *html, *body;
> HTMLDocumentNode *This = impl_from_IMarkupServices(iface);
> - FIXME("(%p)->(%s,%lx,%p,%p,%p)\n", This, debugstr_w(pchHTML), dwFlags, ppContainerResult, pPointerStart, pPointerFinish);
> - return E_NOTIMPL;
> - TRACE("(%p)->(%s,%lx,%p,%p,%p)\n", This, debugstr_w(pchHTML), dwFlags, ppContainerResult, pPointerStart, pPointerFinish);
> -
> - if(dwFlags != 0)
> -
>    FIXME("flags %lx not implemented.\n", dwFlags);
> - if(pPointerStart || pPointerFinish) {
> -
>    FIXME("Pointers not implemented.\n");
> -
>    return E_NOTIMPL;
> - }
> -
> - hres = IMarkupServices_CreateMarkupContainer(iface, &container);
> - if(hres != S_OK)
> -
>    return hres;

Since you know we're dealing with our own implementation of the interface, we know that those QIs can't fail. You could as well use assert or skip it to simplify it.

On the other hand, other functions may return valid errors.