Re: [PATCH v21 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/file.c:
> - int   _charbuf;
> - int   _bufsiz;
> - char* _tmpfname;
>
> +};
> -
>
> +static void test_iobuf_layout(void)
> +{
> - char *tempf;
> - FILE *file;
> - char *ptrold;
> - int cntold;
> -
> - ok(offsetof(FILE, _base)==offsetof(struct test_iobuf, _base) &&
> -
> offsetof(FILE, _cnt)==offsetof(struct test_iobuf, _cnt), "FILE layout incorrect");
>
> +#ifdef _UCRT
> - ok(stdout!=stdin+1, "ucrt stdout FILE must not be adject to stdin");

Does any application depend on that? It looks like an implementation detail that no application should depend on. Also ok messages needs to end with `\n` (`ok(..., "test\n");`).