On Mon Dec 11 10:54:07 2023 +0000, Petrichor Park wrote:
One thing I have noticed is that if there's shader code that doesn't compile at all, there's not really a helpful message. It says `Test failed: Got unexpected hr 0x80004005.` on a line *after* the code block. I don't think it's the world's biggest priority because compile errors aren't really what we're testing for here, though.
Yeah, one fallout of this change is that actions that happen at the end of a section (i.e. most prominently code compilation, but also setting resources) get the line number of the starting of the following section, which can be confusing. It shouldn't be too hard to fix that, though: I just need to delay `vkd3d_test_push_context()` a little bit an push another context for the `if (!ret || line[0] == '[')` block in `shader_runner.c`.