Re: [PATCH v6 0/14] MR372: vkd3d-shader/dxil: Read metadata and signatures.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> -
>    WARN("Entry point definition is not a value.\n");
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_ENTRY_POINT,
> -
>            "Entry point definition is not a metadata value.");
> -
>    return VKD3D_ERROR_INVALID_SHADER;
> - }
> -
> - value = m->u.value;
> - if (!sm6_value_is_function_dcl(value))
> - {
> -
>    WARN("Entry point value is not a function definition.\n");
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_ENTRY_POINT,
> -
>            "Entry point metadata value does not contain a function definition.");
> -
>    return VKD3D_ERROR_INVALID_SHADER;
> - }
> -
> - sm6->entry_point = value->u.function.name;

May it be sensible to `WARN()` if this name doesn't match whatever is stored in `entry_node->operands[1]`?