Re: [PATCH v4 0/3] MR1199: xmllite/writer : Implement a few APIs

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/xmllite/writer.c:
> {
> - xmlwriter *This = impl_from_IXmlWriter(iface);
> - xmlwriter *writer = impl_from_IXmlWriter(iface);
> - HRESULT hr = S_OK;
> - unsigned int count;
> - FIXME("%p %s %d\n", This, wine_dbgstr_w(pwch), cwch);
> - TRACE("%p, %s, %d.\n", iface, debugstr_wn(pwch, cwch), cwch);
> - switch (This->state)
> - if ((pwch == NULL && cwch != 0))
> -
>    return E_INVALIDARG;
> - else if ((pwch == NULL && cwch == 0))
> -
>    return S_OK;
> - else if ((is_empty_string(pwch) && cwch == 0))
> -
>    return S_OK;

You should not be reading input string at all, if given length is 0. Also please change pwch/cwch names to something more readable.