Re: [PATCH v7 0/2] MR8459: urlmon: Add PersistentZoneIdentifier semi-stub

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/urlmon/tests/zone_id.c:
> -
>    { NULL, E_NOTIMPL },
> -
>    S_OK,
> -
>    { L"00000000-0000-0000-0000-000000000000", STGM_READ | STGM_SHARE_EXCLUSIVE, S_OK },
> -
>    S_OK,
> -
>    { URLZONE_LOCAL_MACHINE, S_OK }
> - },
>
> +};
> -
>
> +static void test_uninitialized(void)
> +{
> - const char uninit_tests[] = "uninitialized:";
> - const zone_id_op_test get = { URLZONE_UNTRUSTED, HRESULT_FROM_WIN32(ERROR_NOT_FOUND) };
> - const zone_id_op_test set = { URLZONE_INTERNET, S_OK };
> - const get_cur_file_test get_cur_file = { NULL,  E_NOTIMPL };
> - const load_file_test load = { NULL, STGM_READ, E_INVALIDARG };
> - const save_file_test save = { NULL, FALSE, E_INVALIDARG };

These don’t really make things easier to follow, you could just use expected values directly in the `ok()` statements below. Structs like that are useful when testing multiple value sets, but for one-offs like this, I think they actually make the code harder to read.