On Thu Jan 19 15:25:52 2023 +0000, Giovanni Mascellani wrote:
I won't block the MR on that, but I don't like this style: `component` is really a number here, not a boolean value; in other words, zero is not a value that is more special than any other. So I would write `component == 0`, rather than using operator `!` which gives to the reader the impression that zero is a qualitatively different value from any other.
I agree, I will change it while I am rebasing. (albeit... it is on one of Zeb's patches, and... I feel like we had a similar conversation a year ago, but I am not sure...)