Re: [PATCH 0/1] MR3445: server: Open files in blocking mode in create_file

[Jinoh Kang (＠iamahuman)]

On Sat Jul 29 06:51:48 2023 +0000, Paul Gofman wrote:
> For the record, I didn't say that it is a bug in Wine, I think it is a
> bug in 9pfs as docs suggest that O_NONBLOCK has no effect on regular
> files. What I noted is that the same docs advises against using
> O_NONBLOCK with regular files and expect sync behaviour because it can
> in theory change in the future (but not so far).
> Unfortunately I can't easily comment on correctness of this change. I
> suspect that O_NONBLOCK might be actually needed for something and
> unconditionally removing it will break that something, but can't
> immediately guess which case is that.

For one, it'll indefinitely block the wineserver if an app accidentally tries to open a FIFO with the other half not open.