Re: [PATCH v3 0/11] MR8960: mshtml: Implement XDomainRequest.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/xmlhttprequest.c:
> static HRESULT WINAPI HTMLXDomainRequest_open(IHTMLXDomainRequest *iface, BSTR bstrMethod, BSTR bstrUrl)
>  {
>      HTMLXDomainRequest *This = impl_from_IHTMLXDomainRequest(iface);
> - VARIANT vtrue, vempty;
> - nsAString nsstr;
> - HRESULT hres;
> - WCHAR *p;
> - FIXME("(%p)->(%s %s)\n", This, debugstr_w(bstrMethod), debugstr_w(bstrUrl));
> - TRACE("(%p)->(%s %s)\n", This, debugstr_w(bstrMethod), debugstr_w(bstrUrl));
> - return E_NOTIMPL;
> - if((p = wcschr(bstrUrl, ':')) && p[1] == '/' && p[2] == '/') {

This seems fragile. I think this is meant to check if URL is not relative? If yes, then what if it's relative but the document is not http?

Is it even specific to XDR and doesn't apply to XHR? Could we just remove that check?