Re: [PATCH v8 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c:
> - /* Ensure dirh is in a failure state */
> - test_NtQueryDirectoryFile_mask(dirh, TRUE, &notatestfile, STATUS_NO_MORE_FILES, NULL, FALSE);
> - test_NtQueryDirectoryFile_mask(dirh, TRUE, &emptymask, STATUS_NO_MORE_FILES, NULL, FALSE);
> - test_NtQueryDirectoryFile_mask(dirh, FALSE, &emptymask, STATUS_NO_MORE_FILES, NULL, FALSE);
> -
> - /* Test empty mask with a previously used handle that last returned STATUS_SUCCESS */
> - /* Ensure dirh is in a success state */
> - test_NtQueryDirectoryFile_mask(dirh, TRUE, &testmask, STATUS_SUCCESS, NULL, FALSE);
> - test_NtQueryDirectoryFile_mask(dirh, TRUE, &emptymask, STATUS_SUCCESS, NULL, FALSE);
> - test_NtQueryDirectoryFile_mask(dirh, FALSE, &emptymask, STATUS_SUCCESS, NULL, FALSE);
> -
> - /* Open a handle for our test directory to test null masks with a fresh handle */
> - status = pNtOpenFile(&dirh_test_fresh_null, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ,
> -
>                     FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE);
> - ok( status == STATUS_SUCCESS, "failed to open handle to dir '%s' for testing NULL masks, ret 0x%lx, error %ld\n", testdir, status, GetLastError() );
> - if (status != STATUS_SUCCESS)

there's no need to skip the rest of the test here. from what I've seen the first test for checking that the feature is present should be sufficient.