Re: [PATCH v9 0/10] MR4982: Load and play MIDI

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
> -
>                if (event->data.integer == 0)
> -
>                {
> -
>                    WARN("Invalid tempo value 0\n");
> -
>                    hr = E_FAIL;
> -
>                }
> -
>            }
> -
>        }
> -
>    }
> -
>    else
> -
>    {
> -
>        event->data.variable.data = malloc(length);
> -
>        if (!event->data.variable.data) return E_OUTOFMEMORY;
> -
>        event->data.variable.size = length;
> -
>        hr = stream_read_accumulate(stream, event->data.variable.data, length, total_bytes_read);
> -
>    }
> -
>    TRACE("MIDI meta event type %#02x, length %lu, time +%lu\n", event->type, length, event->deltaTime);

Here and below you might print the event parsing message after a possibly a failed read, I think this could be confusing.