2 Dec
2023
2 Dec
'23
1:03 a.m.
On Fri Dec 1 19:51:25 2023 +0000, Zebediah Figura wrote:
This test doesn't make any sense. If it's that the type we return is correct except for the bit rate, then let's just put a todo_wine on that statement. Or, if we want to be a bit stronger, we can do something like
/* We don't return the correct bit rate, but we still want to make sure * that regressions in other fields aren't hidden by a todo_wine. */ todo_wine ok(mt->dwBitRate == expect->dwBitRate); mt->dwBitRate = expect->dwBitRate;
Problem is that statement is a memcmp of the entire pbFormat, and it's inside compare_media_types(), inside test_stream_output_type().
But yes, those variables aren't beautiful either. Sure, let's do it.