On 9/13/22 06:56, Henri Verbeet (@hverbeet) wrote:
Maybe, but I don't see why..?
What I imagine happens is that the application uses a single indirect buffer containing information for multiple draws, and then uses the offset argument to select between them. The current code would execute draws for the indirect draw selected by the application, but also for any subsequent entries in the buffer. The subsequent entries may then either contain uninitialised data themselves, or refer to data that's uninitialised/stale/not ready.
Still, while I don't doubt the change is correct, the commit message could probably be slightly more elaborate.
I didn't look at what the application actually did, although Philip might have, but that seems like the most likely explanation.