Re: [PATCH v3 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/toolbar.c:
>  TBUTTON_INFO *btnPtr;
>  INT nRunIndex;
>
> - if ((nIndex < 0) || (nIndex > infoPtr->nNumButtons))
> - return -1;
> - /* check index button */
> - btnPtr = &infoPtr->buttons[nIndex];
> - if (!TOOLBAR_CheckIndexButton(btnPtr, infoPtr, nIndex))
> -
>    return -1;

Don't mix tabs and spaces for indentation. You either use tabs or spaces. Same for other places.