Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c:
> -
>
> +/**********************************************************************
> -
> -
>      wayland_init
> -
> -
> -
> - Initialise a wayland instance.
> - */
>
> +BOOL wayland_init(struct wayland *wayland)
> +{
> - struct wl_display *wl_display_wrapper;
> -
> - TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display);
> -
> - wl_list_init(&wayland->thread_link);
> -
> - wayland->process_id = GetCurrentProcessId();
> - wayland->thread_id = GetCurrentThreadId();

Those are redundant for this commit. It's trivial to add when needed and introducing it later would make things much easier to review, because reviewer would need to jump between MR and your branch much less. I would suggest to leave thread_link, thread_id, process_id and initialized out of this MR. (Also, if process_id is always equal to `GetCurrentProcessId()`, I don't think there is much point in storing it).