On Thu Jul 6 13:44:11 2023 +0000, Alexandre Julliard wrote:
Recent nameless struct/union changes broke MSVC Clang builds. That's
because `VARIANT` still doesn't skip names when `__STDC__` is defined, which is true for most configs. I'd argue that it should be true in all configs. MSVC clang not defining `__STDC__` is a bug IMHO.
MSVC does not define it by default or even if you specify -std:c*, there is a separated option to enable it [1] (only in new MSVC and clang does not yet seem to implement it). so clang is compatible in this aspect and that's what MSVC-aware code expects. I think that the current behavior would not be considered a bug upstream.
Would you prefer if I change the logic to make clang use current mingw behavior (instead of the other way around)?
[1] https://learn.microsoft.com/en-us/cpp/build/reference/zc-stdc?view=msvc-170