On Wed Sep 27 14:22:38 2023 +0000, Giovanni Mascellani wrote:
Could the last two patches be splitted to be shorter? I haven't read in detail yet, but in `sm6_parser_metadata_init()` it seems that the various cases could be added incrementally. In the following commit I guess `sm6_parser_find_named_metadata()` could initially be a stub and implemented later in a few commits.
Certainly for `sm6_parser_metadata_init()`, but testing each patch would be a problem unless the default case `continue`s, and then we check `failed` on return. Otherwise it may error out on a test shader before the new code is run. I'm not sure if it's worth messing with, but Henri may like to comment.
For the others, maybe it would be better if `sm6_parser_find_named_metadata()` and `sm6_parser_entry_point_init()` were added first, before `sm6_parser_signatures_init()`.