On Wed Nov 2 14:34:17 2022 +0000, Gabriel Ivăncescu wrote:
Well I can certainly call it if frag_nav is TRUE, but I wanted to re-use the post_data stuff. I'm thinking of moving those variables outside the if block, I think that should be fine and much simpler.
In its current form, super_navigate() supports properly only the main content window. It's very likely that IHTMLPrivateWindow::SuperNavigate is broken for frames and it's not obvious how it should behave. Your patch uses it for frames, but only when doing fragment-only navigation. That logic seems questionable in general and in practice, it would mean that we'd do CGID_ShellDocView notification for non-top level documents. I'd expect that we should either do it for all frame navigations or (more likely) we shouldn't do it for fragment-only frame navigation.