Re: [PATCH 0/2] MR7013: odbc32: Add null pointer checks.

[Hans Leidekker (＠hans)]

On Mon Dec 16 10:14:35 2024 +0000, Owen Rudge wrote:
> Adding in some tracing to the code, it looks like the app is binding 3
> columns, but not consecutive columns, and we're crashing when trying to
> access the first non-bound column:
> 011c:0120:trace:odbc:SQLBindCol (StatementHandle 00000000196C7870,
> ColumnNumber 1, TargetType 1, TargetValue 000000001966D770, BufferLength
> 41, StrLen_or_Ind 000000000572E8D6)
> 011c:0120:trace:odbc:SQLBindCol Returning 0
> 011c:0120:trace:odbc:SQLBindCol (StatementHandle 00000000196C7870,
> ColumnNumber 2, TargetType 4, TargetValue 000000000572E8EC, BufferLength
> 4, StrLen_or_Ind 000000000572E900)
> 011c:0120:trace:odbc:SQLBindCol Returning 0
> 011c:0120:trace:odbc:SQLBindCol (StatementHandle 00000000196C7870,
> ColumnNumber 6, TargetType 1, TargetValue 0000000019542250, BufferLength
> 21, StrLen_or_Ind 000000000572E92A)
> 011c:0120:trace:odbc:SQLBindCol Returning 0
> 011c:0120:trace:odbc:SQLFetch (StatementHandle 00000000196C7870)
> 011c:0120:trace:odbc:update_result_lengths (sql param output), bind_col
> count: 6 bind_param count: 0
> 011c:0120:trace:odbc:len_to_user ptr: 000000000572E8D6 len:
> 00000000195421C0 row_count: 1 width: 8
> 011c:0120:trace:odbc:len_to_user ptr: 000000000572E900 len:
> 0000000019542220 row_count: 1 width: 8
> 011c:0120:trace:odbc:len_to_user ptr: 0000000000000000 len:
> 0000000000000000 row_count: 1 width: 8

If SQLBindCol() was never called for a column then ptr will be NULL so checking ptr should be sufficient.