Re: [PATCH v2 0/1] MR5098: wined3d: Use CRT allocation functions.

[Alex Henrie (＠alexhenrie)]

On Tue Feb 20 01:51:37 2024 +0000, Zebediah Figura wrote:
> > @@ -3020,10 +3020,7 @@ static void *wined3d_cs_st_require_space(struct
>
> wined3d_device_context *context,
> >      void *new_data;
> >
> >      new_size = max(size, cs->data_size * 2);
> > -
> >    if (!cs->end)
> > -
> >        new_data = heap_realloc(cs->data, new_size);
> > -
> >    else
> > -
> >        new_data = heap_alloc(new_size);
> > -
> >    new_data = realloc(cs->data, new_size);
> >    if (!new_data)
> >        return NULL;
>
> This is a functional change.

Thanks for catching that. I think that as I was going through the code, I saw `if (!cs->end)` and thought it said `if (!cs->data)`. I double-checked just now that I didn't make the same mistake with any other instances of realloc.