31 Aug
2023
31 Aug
'23
8:28 a.m.
On Tue Aug 29 10:22:07 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=136798 Your paranoid android. === debian11 (32 bit report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit ar:MA report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit de report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit fr report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit he:IL report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit hi:IN report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit ja:JP report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11 (32 bit zh:CN report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11b (32 bit WoW report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. === debian11b (64 bit WoW report) === d3dcompiler_43: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. d3dcompiler_46: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. d3dcompiler_47: hlsl_d3d9.c:561: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:585: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:659: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:702: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1180: Test failed: Test 0: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 1: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1180: Test failed: Test 2: Got unexpected value {2.47058839e-001, 0.00000000e+000, 2.47058839e-001, 0.00000000e+000}. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001. hlsl_d3d9.c:1174: Test failed: Failed to compile shader, hr 0x80004001.
AFAICS, most of those were "accidentally" passing with older vkd3d releases, but then vkd3d-shader started to properly return compilation failures on unsupported features so that now we don't pass these tests anymore. I think we want to restore todo_wines for those. I can write a patch for this, to be squashed into 3b2a47dec5747bbb3dd443fb3380efcd88686fa7, if you like. How do you prefer that I send it your way? I'll default to attaching it here if I don't hear anything :smile:
I don't seem to reproduce the test failures at line 1180 locally. The test results suggest that there is some surprising inaccuracy in the sampled texture color on the test machines. The generated pixel shaders look correct though and are virtually identical to the native-generated ones, so I guess we should just raise the test tolerance (i.e. the shader does no math, I don't see how wined3d could mess any of this up, I'd blame the driver and move on...) For this one it would be raising the last argument to the compare_vec4() call on line 1180 to higher powers of 2 until the test passes.