Re: [PATCH v6 0/4] MR656: vkd3d-shader/ir: Introduce a better CFG structurizer, part 1.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
>  return ret;
>
> }
>
> +/* Block A dominates block B if every path from the entry point to B
> -
> - must pass through A. Naively computer the set of blocks that are
> -
> - dominated by `reference' by running a graph visit starting from the
> -
> - entry point (which must be the initial value of `current') and
> -
> - avoiding `reference'. Running this for all the blocks takes
> -
> - quadratic time: if in the future something better is sought after,
> -
> - the standard tool seems to be the Lengauer-Tarjan algorithm. */
>
> +static void vsir_cfg_compute_dominators_recurse(uint32_t *dominates, struct vsir_block *current,
> -
>    struct vsir_block *reference)

Any particular reason for passing `dominates` to this function? Looks like it can be accessed from `reference` on each recursion.