Re: [PATCH v2 0/3] MR589: vkd3d-shader/dxil: Implement DX intrinsic SplitDouble.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
>  instruction_dst_param_init_ssa_vector(ins, VKD3D_VEC4_SIZE, sm6);
>
> }
>
> +static void sm6_parser_emit_dx_split_double(struct sm6_parser *sm6, enum dx_intrinsic_opcode op,
> -
>    const struct sm6_value **operands, struct function_emission_state *state)
>
> +{
> - struct vkd3d_shader_instruction *ins = state->ins;
> - struct vkd3d_shader_src_param *src_param;
> -
> - vsir_instruction_init(ins, &sm6->p.location, VKD3DSIH_MOV);
> - src_param = instruction_src_params_alloc(ins, 1, sm6);
> - src_param_init_from_value(src_param, operands[0]);

Minor nitpick, but I'd use `&src_param[0]` instead of `src_param`.