On Fri May 16 19:15:49 2025 +0000, Alfred Agrell wrote:
Necessary, no, but it's inconsistent. It's no more important than other code style issues, but still worth fixing. Also idempotent means that if you do it twice, the result is the same as doing it once, for example ShowWindow(hwnd, SW_SHOW) or fflush(). QueryInterface is not idempotent, it changes the refcount. ...or, well, it should change the refcount. Looks like you forgot that.
you are right, I did put it into the other patch implementing the Bitmap handling too, but should have been here