[PATCH v2 2/6] sapi: Ignore read_only in ISpRegDataKey::SetKey.

[Shaun Ren]

From: Shaun Ren

---
 dlls/sapi/tests/token.c | 24 ++++++++++++++++++++++++
 dlls/sapi/token.c       |  4 +---
 2 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/dlls/sapi/tests/token.c b/dlls/sapi/tests/token.c
index 792b65a6366..603e2143ff9 100644
--- a/dlls/sapi/tests/token.c
+++ b/dlls/sapi/tests/token.c
@@ -76,6 +76,30 @@ static void test_data_key(void)
     ISpDataKey_Release(sub);

ISpRegDataKey_Release( data_key );
+
+    hr = CoCreateInstance( &CLSID_SpDataKey, NULL, CLSCTX_INPROC_SERVER,
+                           &IID_ISpRegDataKey, (void **)&data_key );
+    ok( hr == S_OK, "got %08lx\n", hr );
+
+    res = RegOpenKeyExA( HKEY_CURRENT_USER, "Software\Winetest\sapi", 0, KEY_ALL_ACCESS, &key );
+    ok( res == ERROR_SUCCESS, "got %ld\n", res );
+
+    hr = ISpRegDataKey_SetKey( data_key, key, TRUE );
+    ok( hr == S_OK, "got %08lx\n", hr );
+
+    hr = ISpRegDataKey_SetStringValue( data_key, L"Voice2", L"Test2" );
+    ok( hr == S_OK, "got %08lx\n", hr );
+
+    hr = ISpRegDataKey_GetStringValue( data_key, L"Voice2", &value );
+    ok( hr == S_OK, "got %08lx\n", hr );
+    ok( !wcscmp( value, L"Test2" ), "got %s\n", wine_dbgstr_w(value) );
+    CoTaskMemFree( value );
+
+    hr = ISpRegDataKey_CreateKey( data_key, L"Testing2", &sub );
+    ok( hr == S_OK, "got %08lx\n", hr );
+    ISpDataKey_Release(sub);
+
+    ISpRegDataKey_Release( data_key );
 }

static void test_token_category(void)
diff --git a/dlls/sapi/token.c b/dlls/sapi/token.c
index 6c862bb030c..74ef6884fbc 100644
--- a/dlls/sapi/token.c
+++ b/dlls/sapi/token.c
@@ -40,7 +40,6 @@ struct data_key
     LONG ref;

HKEY key;
-    BOOL read_only;
 };

static struct data_key *impl_from_ISpRegDataKey( ISpRegDataKey *iface )
@@ -253,8 +252,8 @@ static HRESULT WINAPI data_key_SetKey( ISpRegDataKey *iface,

if (This->key) return SPERR_ALREADY_INITIALIZED;

+    /* read_only is ignored in Windows implementations. */
     This->key = key;
-    This->read_only = read_only;
     return S_OK;
 }

@@ -287,7 +286,6 @@ HRESULT data_key_create( IUnknown *outer, REFIID iid, void **obj )
     This->ISpRegDataKey_iface.lpVtbl = &data_key_vtbl;
     This->ref = 1;
     This->key = NULL;
-    This->read_only = FALSE;

hr = ISpRegDataKey_QueryInterface( &This->ISpRegDataKey_iface, iid, obj );