On Thu Dec 1 12:59:58 2022 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=127063 Your paranoid android. === debian11 (32 bit report) === comctl32: dpa.c:216: Test failed: ret=1 error=0 dpa.c:216: Test failed: ret=1 error=1411
This looks genuine, I'll have a look.
I think I can also add an additional safety check to detect heap mismatches that were recently introduced with CRT alloc conversions, and which are causing most of the crashes in https://gitlab.winehq.org/wine/wine/-/merge_requests/1628.