Re: [PATCH v3 0/6] MR491: vkd3d-shader/dxil: Handle control flow instructions.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> - return true;
>
> +}
> -
>
> +static unsigned int sm6_function_alloc_block_id(struct sm6_function *function)
> +{
> - return ++function->block_current_id;
>
> +}
> -
>
> +static struct sm6_block *sm6_function_create_block(struct sm6_function *function)
> +{
> - struct sm6_block *block;
> -
> - if (!sm6_function_blocks_reserve(function, function->block_count + 1) || !(block = sm6_block_create()))
> -
>    return NULL;
> -
> - block->synthetic_id = sm6_function_alloc_block_id(function);

Unless I'm missing something, `synthetic_id` is just the block position in the `blocks` array plus 1. Do we need to store it explicitly, or can we directly use the position in the array as block id?