On 10/16/22 17:23, Rémi Bernon (@rbernon) wrote:
On Sun Oct 16 22:15:26 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list:
From "[PATCH 09/13] ntdll: Import valgrind headers for PE side ntdll.": One of the motivating factors for 9951f2f43 was to allow including headers like valgrind from PE code. I'm not immediately sure how to solve the problem of detecting the header, but it doesn't seem obviously intractable, and potentially preferable to do that rather than import more actively developed external code into the project.You can't do that because these headers use 64bit `long` types. This is the Valgrind ABI and it's very unlikely to change. It's been pretty much untouched for 20 years now, with only a few advanced request additions.
I think there's room for the ABI to change if the current ABI just is completely broken with a given configuration. I suppose working around that bug, whether on a temporary or permanent basis, can be deemed a worthwhile workaround (though opinions may vary), but it'd at least be useful to put that information somewhere (say, the commit message). As it is I had no way of knowing that this header was modified, period.