Re: [PATCH 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/comctl32/tests/button.c:
> - {
> -
>    { WM_SETFOCUS, sent },
> -
>    { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_SETFOCUS) },
> -
>    { WM_PAINT, sent },
> -
>    { WM_NCPAINT, sent|defwinproc|optional }, /* FIXME: Wine sends it */
> -
>    { 0 }
> - };
> -
> - hwnd = CreateWindowExA(0, "TestParentClass", "Test parent", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
> -
>                           100, 100, 200, 200, 0, 0, 0, NULL);
> - ok(hwnd != 0, "Failed to create parent window\n");
> -
> - for (type = BS_PUSHBUTTON; type <= BS_DEFCOMMANDLINK; ++type)
> - {
> -
>    if (type != BS_RADIOBUTTON && type != BS_AUTORADIOBUTTON)
> -
>        continue;

This looks strange. You don't need to iterate like that just to use two values.