Re: [PATCH v3 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
>  return block;
>
> }
>
> +static void sm6_parser_emit_dx_store_output(struct sm6_parser *sm6, struct sm6_block *code_block,
> -
>    enum dx_intrinsic_opcode op, const struct sm6_value **operands, struct vkd3d_shader_instruction *ins)
>
> +{
> - struct vkd3d_shader_src_param *src_param;
> - struct vkd3d_shader_dst_param *dst_param;
> - const struct shader_signature *signature;
> - unsigned int element_id, column_index;
> - const struct signature_element *e;
> - const struct sm6_value *value;
> -
> - element_id = sm6_value_get_constant_uint(operands[0]);
> - column_index = sm6_value_get_constant_uint(operands[2]);

Why `column_index` rather than, say, `component_index`? Is there supposed to be a `row_index` somewhere?