Re: [PATCH v4 0/3] MR267: vkd3d: Implement GetResourceTiling().

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about tests/d3d12.c:
> -
> -
>    if (tests[i].dim == D3D12_RESOURCE_DIMENSION_BUFFER)
> -
>        resource_desc.Layout = D3D12_TEXTURE_LAYOUT_ROW_MAJOR;
> -
> -
>    hr = ID3D12Device_CreateReservedResource(context.device, &resource_desc,
> -
>            D3D12_RESOURCE_STATE_GENERIC_READ, NULL, &IID_ID3D12Resource, (void **)&resource);
> -
>    todo_if(is_radv_device(context.device) && tests[i].todo_radv)
> -
>    ok(hr == S_OK, "Failed to create reserved resource, hr %#x.\n", hr);
> -
> -
>    if (hr != S_OK)
> -
>        continue;
> -
> -
>    ID3D12Device_GetResourceTiling(context.device, resource, &resource_tile_count, &packed_mip_info, &tile_shape, &tilings_count, 0, tilings);
> -
>    assert(tilings_count <= ARRAY_SIZE(tilings));
> -
> -
>    ok(resource_tile_count != 0xdeadbeef && resource_tile_count >= tests[i].expected_tile_count,

Why is this a `>=`? In which cases more tiles than expected are declared? Later you even check the exact value for `resource_tile_count`, so maybe this check (and the corresponding field in the test array) is redundant?