23 Aug
2023
23 Aug
'23
3:14 a.m.
- 1/7, 2/7, and 4/7 add dead code, and I cannot easily guess how 1/7 and 2/7 will be used.
- How much utility does 3/7 add? It's just push_event() but it emits GST_ERROR. In what cases is GStreamer not already emitting that error? Then again, if it makes debugging easier I won't argue against it.
- I don't think we want to do dynamic linking just because GStreamer decided to mark a function deprecated for having a less than ideal name. I think it makes more sense to use the old name and just add -Wno-deprecated-declarations.
- 7/7 does not at all do what it says it does.