On Wed Mar 1 12:26:25 2023 +0000, Giovanni Mascellani wrote:
You're lucky in having an opinion: in these cases I'm always terribly undecided on which one to use, and waste a lot of time pondering the two (irrelevant) alternatives. https://en.wikipedia.org/wiki/Buridan%27s_ass
I will give my opinion as well, then :)
In this case, I am more inclined now for `var->offset_reservation.index` since the raison d'etre of `proper_offset` is to perform the check above, and the assignment would be giving it a secondary purpose.
OTOH, and the reason why I probably used `proper_offset` here, is that I got the feeling that in case of an invalid offset the program would be more stable before exiting, because otherwise the var will end with the misaligned offset provided by the user. But now `var->buffer_offset` doesn't seem to be used in a way that alters the flow of execution before the next exit point (which is before writing the sm1/sm4). Error reporting of the offset reservation overlaps could differ slightly though.