Re: [PATCH v2 0/7] MR4982: Draft: Load and play MIDI

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmband/bandtrack.c:
>      return DMUS_E_TYPE_UNSUPPORTED;
>
>  if (IsEqualGUID(type, &GUID_BandParam))
> -
>    FIXME("GUID_BandParam not handled yet\n");
> - {
> -
>    struct band_entry *entry = calloc(1, sizeof(*entry));
> -
>    DMUS_BAND_PARAM *band_param = param;
> -
>    if (!entry)
> -
>        return E_OUTOFMEMORY;
> -
>    entry->band = band_param->pBand;
> -
>    entry->head.lBandTimeLogical = band_param->mtTimePhysical;
> -
>    entry->head.lBandTimePhysical = band_param->mtTimePhysical;
> -
>    IDirectMusicBand_AddRef(entry->band);
> -
>    list_add_tail(&This->bands, &entry->entry);
> - }

Is this really what this is supposed to be doing? This would need some tests.