Re: [PATCH v3 0/4] MR3554: mmdevapi: fixes for Yousician

[Chip Davis (＠cdavis5e)]

Chip Davis (@cdavis5e) commented about dlls/mmdevapi/tests/render.c:
>          broken(hr == E_NOINTERFACE) /* win8 */,
>          "Failed to query IAudioClient3 interface: %08lx\n", hr);
>
> - if(hr == S_OK)
> - if(hr == S_OK){
> -
>    UINT32 default_period, unit_period, min_period, max_period;
> -
> -
>    hr = IAudioClient3_GetSharedModeEnginePeriod(
> -
>        ac3, pwfx, &default_period, &unit_period, &min_period, &max_period);
> -
>    ok(hr == S_OK, "GetSharedModeEnginePeriod returns %08lx\n", hr);

This should have a `todo_wine` on it, which marks the test as "expected to fail on Wine." Then you remove it in patch 2, since it is no longer expected to fail then.

Each commit is expected to build properly and pass tests--or at least, it shouldn't add any new failures. This requirement makes bisection easier.